replace the hash algorithm with the one used in byterun/hash.c #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2016 16:32
…o: test the block and some weird js values
kevinbarabash
pushed a commit
to kevinbarabash/rescript-compiler
that referenced
this pull request
Dec 24, 2021
This way things are less error prone However... Having to check for newline every `next` regressed the perf back to the level after rescript-lang#269 😭... it's ok, we've earned it. There's been nothing but readability cleanup along the way so it's still a net win for reading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:: test the block and some weird js values